Fix React warning in ButtonGroup

[chunkerchunker]

• [ x ] I have followed the Your First Code Contribution section of the Contributing guide

Summarize the changes made and the motivation behind them.

This change fixes the following issue that was introduced recently in commit d0dc810:

ButtonGroup was adding positionInGroup to all children rather than just Buttons. For example, in the following, both the Buttons and the child spans get positionInGroup props:

<Button.Group>
  <Button><span>b1</span></Button>
  <Button><span>b2</span></Button>
</Button.Group>

This results in a React warning: “Warning: React does not recognize the positionInGroup prop on a DOM element...”

The review comment on the original commit hints at this issue as well:

https://github.com/themesberg/flowbite-react/pull/1273#issuecomment-1991553683

Summary by CodeRabbit

• Refactor
  • Enhanced the logic for determining button positions within groups to improve usability.

[stackblitz[bot]]

Run & review this pull request in StackBlitz Codeflow.

[changeset-bot[bot]]

⚠️ No Changeset found

Latest commit: 8f1b29613526040af89cc63ca94af01528077b22

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[vercel[bot]]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
flowbite-react	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 1, 2024 3:22am
flowbite-react-storybook	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 1, 2024 3:22am

[coderabbitai[bot]]

Walkthrough

This update refines the import approach for ButtonProps and enhances the logic for determining button positions within groups, ensuring a smoother and more intuitive grouping of buttons in the UI component.

Changes

File Path	Change Summary
.../Button/ButtonGroup.tsx	Modified ButtonProps import and refactored button positioning logic.

Possibly related issues

• themesberg/flowbite-react#900: The refactoring could potentially address the React error when adding conditional Buttons to a Button.Group by improving how button positions and conditions are handled.
• themesberg/flowbite-react#855: If the changes include adjustments in handling wrapped text, this could potentially ensure uniform button heights within Button.Groups, addressing the issue of varying button heights due to text wrapping.

Poem

In the realm of code where buttons align,
A rabbit hopped, making designs refine.
With each leap and bound, errors unwind,
Grouped buttons in harmony, you'll find.
🐰✨
"To group or not?" No more debate,
For CodeRabbit's touch makes all integrate.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[chunkerchunker]

formatting

Apologies, fixed.