flowbite-react icon indicating copy to clipboard operation
flowbite-react copied to clipboard

Updated FlowbiteTableTheme.header.base to dark:text-gray-300

Open lancegliser opened this issue 11 months ago • 9 comments

Summarize the changes made and the motivation behind them. Modified table header cells to have sufficient AA contrast in the stock theme.

Reference related issues using # followed by the issue number. #1309

Summary by CodeRabbit

  • Style
    • Updated the text color in table headers for improved readability.

lancegliser avatar Mar 21 '24 17:03 lancegliser

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

stackblitz[bot] avatar Mar 21 '24 17:03 stackblitz[bot]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flowbite-react ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 5, 2024 9:42pm
flowbite-react-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 5, 2024 9:42pm

vercel[bot] avatar Mar 21 '24 17:03 vercel[bot]

Walkthrough

The modification focuses on enhancing the visual accessibility and aesthetic of table headers by shifting the text color to a lighter shade. This change aims to improve readability and align with accessibility standards, potentially impacting user experience positively.

Changes

File Path Change Summary
packages/ui/src/components/Table/theme.ts Updated dark text color in table theme from dark:text-gray-400 to dark:text-gray-300.

Possibly related issues

  • themesberg/flowbite-react#1309: This change may contribute to improving color contrast in dark mode, aligning with the accessibility concern raised.
    • Reasoning: Adjusting text colors for better contrast directly addresses the need for accessible color ratios.

🐇✨
In the realm of code, where changes abound,
A rabbit hopped in, improvements found.
With a flick and a hop, the colors did shift,
Making headers gleam, spirits to lift.
For accessibility's sake, we hop with pride,
In a brighter, clearer world, we now reside.
🌟🐾


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar Mar 21 '24 17:03 coderabbitai[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.53%. Comparing base (7461173) to head (f37c2e1). Report is 245 commits behind head on main.

:exclamation: Current head f37c2e1 differs from pull request most recent head 0b6477d. Consider uploading reports for the commit 0b6477d to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1310      +/-   ##
==========================================
- Coverage   99.54%   95.53%   -4.01%     
==========================================
  Files         163      217      +54     
  Lines        6621     9685    +3064     
  Branches      401      560     +159     
==========================================
+ Hits         6591     9253    +2662     
- Misses         30      432     +402     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Mar 21 '24 17:03 codecov[bot]

@robert1508 thoughts?

SutuSebastian avatar Mar 25 '24 09:03 SutuSebastian

sync with main or re-do the branch+PR since this one is based on the old version of main (before monorepo setup)

SutuSebastian avatar Mar 29 '24 08:03 SutuSebastian

⚠️ No Changeset found

Latest commit: 0b6477db48172d2f9dbb6b00dbccf3671ad8d03e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Mar 29 '24 18:03 changeset-bot[bot]

@SutuSebastian what's the status here? Updated and have fallen out of date again.

lancegliser avatar Apr 19 '24 13:04 lancegliser

@SutuSebastian what's the status here? Updated and have fallen out of date again.

Waiting for @robert1508 to confirm on the change, because everything whats on flowbite-react should reflect 1-to-1 whats on https://flowbite.com/

SutuSebastian avatar Apr 19 '24 16:04 SutuSebastian