flowbite-react icon indicating copy to clipboard operation
flowbite-react copied to clipboard

docs(remix): added additional notes for using Remix Link API

Open dhavalveera opened this issue 11 months ago • 9 comments

if we are using Remix API Layer Link from @remix-run/react, and using it == as={Link} then replace the href with to, and we can use href if we are not using Link on Navbar.Link & Sidebar.Item

dhavalveera avatar Feb 26 '24 10:02 dhavalveera

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

stackblitz[bot] avatar Feb 26 '24 10:02 stackblitz[bot]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flowbite-react ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 26, 2024 11:00am

vercel[bot] avatar Feb 26 '24 10:02 vercel[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.35%. Comparing base (7461173) to head (3657feb). Report is 195 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1280      +/-   ##
==========================================
- Coverage   99.54%   97.35%   -2.20%     
==========================================
  Files         163      216      +53     
  Lines        6621     9224    +2603     
  Branches      401      538     +137     
==========================================
+ Hits         6591     8980    +2389     
- Misses         30      244     +214     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 26 '24 11:02 codecov[bot]

Hello @SutuSebastian , Sorry to bother you, but can you please review this PR?

dhavalveera avatar Mar 10 '24 01:03 dhavalveera

can we simplify the text a bit? so its more concise and easier to understand

I wrote this explanation with examples for better understanding. but let me try if I can simplify the text. @SutuSebastian

dhavalveera avatar Mar 12 '24 12:03 dhavalveera

Actually, let's wait with this since we'll have a new way of making navigation more friendly and top level config, so the developer doesn't have to repeat itself in all places.

Logic behind: register once -> it just works.

SutuSebastian avatar Mar 12 '24 12:03 SutuSebastian

Actually, let's wait with this since we'll have a new way of making navigation more friendly and top level config, so the developer doesn't have to repeat itself in all places.

Logic behind: register once -> it just works.

Sounds Great!.. I would be happy to help you & contribute with you more on this.

dhavalveera avatar Mar 12 '24 12:03 dhavalveera

Actually, let's wait with this since we'll have a new way of making navigation more friendly and top level config, so the developer doesn't have to repeat itself in all places.

Logic behind: register once -> it just works.

can I close this PR? @SutuSebastian

dhavalveera avatar Mar 31 '24 08:03 dhavalveera

Actually, let's wait with this since we'll have a new way of making navigation more friendly and top level config, so the developer doesn't have to repeat itself in all places. Logic behind: register once -> it just works.

can I close this PR? @SutuSebastian

keep it for a while, so we can close it with reference.

SutuSebastian avatar Mar 31 '24 08:03 SutuSebastian