flowbite-react icon indicating copy to clipboard operation
flowbite-react copied to clipboard

feat: Drawer component

Open dhavalveera opened this issue 1 year ago • 10 comments

  • feat(drawer): created Drawer component

  • This PR creates the Drawer component based on the specs of the core library

  • docs(Drawer): created document page of Drawer component with examples

  • docs(Drawer): improved documentation

dhavalveera avatar Feb 07 '24 09:02 dhavalveera

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flowbite-react ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 15, 2024 8:53am

vercel[bot] avatar Feb 07 '24 09:02 vercel[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (7461173) 99.54% compared to head (86ea8d8) 97.32%. Report is 195 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1265      +/-   ##
==========================================
- Coverage   99.54%   97.32%   -2.23%     
==========================================
  Files         163      222      +59     
  Lines        6621     9487    +2866     
  Branches      401      548     +147     
==========================================
+ Hits         6591     9233    +2642     
- Misses         30      254     +224     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 07 '24 10:02 codecov[bot]

another push of the code changes includes the position of the Drawer (top | right | bottom | left), where default one is left

dhavalveera avatar Feb 07 '24 11:02 dhavalveera

@dhavalveera when I test the example in the docs the drawer is displayed outside the example, covering the documentation left sidebar. My best guess here is that isn't desirable, right?

image

rluders avatar Feb 07 '24 11:02 rluders

@dhavalveera when I test the example in the docs the drawer is displayed outside the example, covering the documentation left sidebar. My best guess here is that isn't desirable, right?

image

Yes @rluders it's not desirable, but I'm not sure how avoid this, maybe change the position or something, would it be possible @rluders Sir, please guide me? 🙏

dhavalveera avatar Feb 07 '24 11:02 dhavalveera

Yes @rluders it's not desirable, but I'm not sure how avoid this, maybe change the position or something, would it be possible @rluders Sir, please guide me? 🙏

TBH, I have no idea. :)

rluders avatar Feb 07 '24 13:02 rluders

@SutuSebastian , I've tried your suggestion as per shared in Discord Channel, by adding the position: relative to the Code Demo Wrapper Code and adding the position: absolute to the Drawer Code, and it worked, as well as I tried to check the Modal & Popover code in my local, and it seems working for me, can you please have a look from the above deployed Vercel Link, please 🙏

dhavalveera avatar Feb 09 '24 11:02 dhavalveera

@dhavalveera would it be possible to have a slide transition? like, when it's left-right it would be cool to have it slide over from outside of the screen instead of just popping up instantaneously

nigellima avatar Feb 10 '24 17:02 nigellima

@dhavalveera would it be possible to have a slide transition? like, when it's left-right it would be cool to have it slide over from outside of the screen instead of just popping up instantaneously

OK, can you try to help me on this, if possible? @nigellima

dhavalveera avatar Feb 11 '24 02:02 dhavalveera

Hello @SutuSebastian , Sorry to bother you, but can you please help me in this PR?

dhavalveera avatar Mar 10 '24 01:03 dhavalveera

Thank you @dhavalveera for getting this started! I just opened a new PR branching off your changes at #1342 and added credits pointing directly to your original work here. I'm going to go ahead and close this PR since all remaining work will be conducted there.

tulup-conner avatar Apr 01 '24 23:04 tulup-conner