matters-server
matters-server copied to clipboard
feat(cfsvc): cloudflare direct image uploading: Implementation
resolves #249
Client side has 3 steps to call this API:
- call
directImageUploadto get an Asset with direct upload url; - post image as file to this direct upload url;
- (async) post result url to directImageUpload, mark
draftboolean to false;
Codecov Report
Attention: 2 lines in your changes are missing coverage. Please review.
Comparison is base (
77c61bb) 58.05% compared to head (6928b15) 58.05%. Report is 1 commits behind head on develop.
Additional details and impacted files
@@ Coverage Diff @@
## develop #3596 +/- ##
========================================
Coverage 58.05% 58.05%
========================================
Files 846 846
Lines 16633 16630 -3
Branches 3058 3058
========================================
- Hits 9656 9655 -1
+ Misses 6298 6296 -2
Partials 679 679
| Files | Coverage Δ | |
|---|---|---|
| src/connectors/systemService.ts | 52.23% <0.00%> (ø) |
|
| src/mutations/system/directImageUpload.ts | 20.51% <50.00%> (+1.46%) |
:arrow_up: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.