matters-server icon indicating copy to clipboard operation
matters-server copied to clipboard

feat(cfsvc): cloudflare direct image uploading: Implementation

Open tx0c opened this issue 2 years ago • 1 comments

resolves #249

Client side has 3 steps to call this API:

  1. call directImageUpload to get an Asset with direct upload url;
  2. post image as file to this direct upload url;
  3. (async) post result url to directImageUpload, mark draft boolean to false;

tx0c avatar Sep 18 '23 07:09 tx0c

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (77c61bb) 58.05% compared to head (6928b15) 58.05%. Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3596   +/-   ##
========================================
  Coverage    58.05%   58.05%           
========================================
  Files          846      846           
  Lines        16633    16630    -3     
  Branches      3058     3058           
========================================
- Hits          9656     9655    -1     
+ Misses        6298     6296    -2     
  Partials       679      679           
Files Coverage Δ
src/connectors/systemService.ts 52.23% <0.00%> (ø)
src/mutations/system/directImageUpload.ts 20.51% <50.00%> (+1.46%) :arrow_up:

... and 1 file with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Oct 04 '23 19:10 codecov[bot]