kld-intersections icon indicating copy to clipboard operation
kld-intersections copied to clipboard

ShapeInfo throws exception: Unable to extract value for size,width,height,w,h

Open istvank opened this issue 4 years ago • 4 comments

Hi, I have an issue with the ShapeInfo for rounded rectangles, rr being a rectangle with rounded corners: ShapeInfo.rectangle({x: rr.x, y: rr.y, w: rr.width, h: rr.height, rx: rr.rx, ry: rr.ry}); it throws an exception:

Uncaught TypeError: Unable to extract value for size,width,height,w,h
    at getValues (ShapeInfo.js? [sm]:59)
    at Function.rectangle (ShapeInfo.js? [sm]:272)

Seems like in the for loop of getValues in ShapeInfo.js, parsePoint shifts the args parameter without creating a copy.

Is that a bug or am I missing something?

Used to work in 0.6.0, but the dependency gp-data-transformer disappeared from npm. :(

istvank avatar May 14 '20 07:05 istvank

Seems like ShapeInfo no longer accepts objects.

istvank avatar May 14 '20 07:05 istvank

Hi @istvank,

If you have a chance, please try the latest on development? I ran your test case above and it seems to be working fine. Please let me know if you run into any other issues.

Thanks for reporting the issue!

thelonious avatar May 14 '20 17:05 thelonious

Hi there! I was getting this error too, but #development indeed got rid of the error.

brettz9 avatar Jul 13 '21 10:07 brettz9

Ok. Once we address the other issue you’re seeing, I can push another release.

Thanks!

On Jul 13, 2021, at 3:38 AM, Brett Zamir @.***> wrote:

 Hi there! I was getting this error too, but #development indeed got rid of the error.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.

thelonious avatar Jul 17 '21 16:07 thelonious