league-gothic icon indicating copy to clipboard operation
league-gothic copied to clipboard

Upgraded to VF for GF

Open bghryct opened this issue 5 years ago • 12 comments

upgraded and expanded for pull request to google fonts

bghryct avatar Feb 05 '20 15:02 bghryct

Just to let you know, @micahbrich and I were poking around fonts yesterday and bumped into this. We do plan to integrate it! Sorry it's taken so long to get some attention. I'm working on some toolchain pieces and on cleaning up the git repositories for all the League fonts. This is actively on our list.

alerque avatar Mar 26 '20 15:03 alerque

Thanks! Happy to talk fonts sometime. lomt really inspired me to work on fonts when I was a student.

bghryct avatar Mar 26 '20 16:03 bghryct

@bghryct I'm a very long time user of League fonts myself but only recently got involved in contributing. I'm not a designer, doing more programming and typesetting work, but feel free to drop into the Gitter room we started the other day.

alerque avatar Mar 26 '20 16:03 alerque

@sursly Did you have an eye on this while working on the variable update in your fork?

alerque avatar Nov 02 '20 11:11 alerque

@alerque nope, I've never seen this

sursly avatar Nov 02 '20 18:11 sursly

@alerque this PR has now diverged from this repo's main branch. At Google Fonts we had got @bghryct 's work onto our sandbox, but we'd now like to sync the 2-3 threads of work (@bghryct GF- and VF- ication, @alerque 's build work, and @sursly 's design work) and publish that. How should we proceed?

davelab6 avatar Aug 05 '21 14:08 davelab6

I'll have another look based on the above info, but from memory when I first reviewed the differences there were two entirely parallel sets of design work and somebody would need to decide which way to go. I'll skim over the status to see where each is at technically, then figure out what design bits should be reviewed.

alerque avatar Aug 06 '21 19:08 alerque

Does anyone want to take a decision, or I can go with whatever is more practical on our end and PR a solution?

RosaWagner avatar Oct 28 '21 10:10 RosaWagner

@RosaWagner again, my work on it from last year might seem familiar to you. I think it needs more love than League Spartan, but it should be in a good place to prep for GF.

sursly avatar Oct 29 '21 00:10 sursly

After analysing all the sources: Tyler's version have corrected curves and expanded glyphset to vietnamese BUT italic and Italic condensed are not compatible. Also Caleb's version (and Mirko's edits) has expanded masters.

RosaWagner avatar Oct 29 '21 10:10 RosaWagner

The italics I made (what, 7 years ago or something?) are pretty bad @RosaWagner, Oblique, and not very good at that. Not worth keeping, in my opinion.

sursly avatar Oct 29 '21 14:10 sursly

Okay, so after analysing the sources deeper and talk with Dave, we decided to onboard Tyler's version as a first step even if the designspace is reduced. It has less masters but wider language coverage, corrected outlines and improved interpolation. So we should have less bug reports with this one. @sursly you will receive a PR from Emma shortly :)

RosaWagner avatar Dec 03 '21 10:12 RosaWagner