angular-cc-library icon indicating copy to clipboard operation
angular-cc-library copied to clipboard

Published 20 hours ago • verified publisher icon thekip

Angular 18 Support

Open s-torrisi opened this issue 1 year ago • 3 comments

At the moment the library does not support angular 18

Is there anything I can do to help update it or is there a planned release date?

s-torrisi avatar Jun 26 '24 13:06 s-torrisi

@thekip , I am waiting for new release of matching angular 18 Thanks

wen9218 avatar Jun 27 '24 07:06 wen9218

yes please, need to move to ngv18 and waiting on this lib <3 TX!

born2net avatar Jun 27 '24 09:06 born2net

Any update on this? 18 has been out for quite sometime.

cwithhart avatar Aug 26 '24 16:08 cwithhart

Can someone help me out. I tried updating the library to 18 but getting an issue when running ng test. It looks like the require() for non es modules isnt working and im not exactly sure the answer. (The code is working just not the tests) https://github.com/cwithhart/angular-cc-library/tree/angular-18-update

cwithhart avatar Sep 03 '24 20:09 cwithhart

@cwithhart can you add me as maintainer to your fork? I created a pull request that would fix the problem with the tests (It is mainly related to an old yarn version and to standalone components)

s-torrisi avatar Sep 04 '24 08:09 s-torrisi

that would be great if more people will work on the project, tx

born2net avatar Sep 04 '24 08:09 born2net

@thekip, can you add me as maintainer to this project too? I'd be glad to help maintain this project also in the future

s-torrisi avatar Sep 04 '24 10:09 s-torrisi

guys, if you want to participate i would be glad to accept PR's

I think updating to the Angular 18 should be as easy as just a peer dep version bump.

timofei-iatsenko avatar Sep 04 '24 11:09 timofei-iatsenko

There it is, I realized it wasn't necessary to merge my code to the other fork before creating the PR:

https://github.com/thekip/angular-cc-library/pull/125

s-torrisi avatar Sep 04 '24 11:09 s-torrisi

@thekip the publishing of the app has failed, have you had a chance to take a look at it?

s-torrisi avatar Sep 06 '24 09:09 s-torrisi

@timofei-iatsenko any news?

s-torrisi avatar Sep 10 '24 13:09 s-torrisi

Sorry, was busy on the job. Will try to bring the pipeline to live now

timofei-iatsenko avatar Sep 10 '24 14:09 timofei-iatsenko

https://www.npmjs.com/package/angular-cc-library/v/3.4.0

timofei-iatsenko avatar Sep 10 '24 14:09 timofei-iatsenko