John Freeman

Results 42 issues of John Freeman

Related to #5028. The Clio trigger from that branch needs to be merged with this one.

This change requires a discussion of whether and how to meet the goal before it is implemented. Here is a list of the top 30 files, under `src/ripple/`, added and...

Feature Request

clang-format-10 is no longer available on the latest version of Ubuntu (23.10). clang-format-15 is the latest version available on the latest [Ubuntu GitHub runner image](https://github.com/actions/runner-images?tab=readme-ov-file#available-images) (22.04). It does a much...

Remove a set of headers included by no files outside of the set.

Trivial
Remove unused code

Adds two CMake functions: - `add_module(library subdirectory)`: Declares an `OBJECT` "library" (a CMake abstraction for a collection of object files) with sources from the given subdirectory of the given library,...

Blocked

Builds and passes all tests, but I have not yet tested compatibility with Clio. Asking for help from the Clio team with that.

Remove unused code

This type should let objects and transactions contain multiple fields for quantities of XRP, IOU, or [MPT](https://github.com/XRPLF/rippled/pull/5108) without duplicating information about the "issue" (represented by `STIssue`). It is a straightforward...

`IOUAmount` has a special representation for zero, but the default constructor `IOUAmount()` has defaulted implementation, which does not land in that special representation. Some odd behavior I'm observing: 1. A...