pertpy icon indicating copy to clipboard operation
pertpy copied to clipboard

FindConservedMarkers implementaion

Open SNOL2 opened this issue 1 year ago • 3 comments

Description of feature

Hi, thanks for your efforts for developing this wonderful framework! I was wondering if there could be an implementaion of Seurat FindConservedMarkers function, which can perform DGE analysis per group(e.g datasets) then combine them. It could be extremely useful especially when batch effects exist. Thanks in advance!

SNOL2 avatar Jun 22 '24 02:06 SNOL2

Noted! Thanks for the feature request. It will take some time because of priorities.

Zethson avatar Jun 22 '24 14:06 Zethson

I won't have the bandwidth to work on this feature for a while, but I'm open to accepting PRs from anyone interested in implementing it.

Zethson avatar Jun 02 '25 09:06 Zethson

@SNOL2:

It could be extremely useful...

Do you have any data backup up that claim? In my hands this function never really yielded trustworthy results and I ended up using muscat instead

...especially when batch effects exist.

If you have a public dataset and some analyses that show how that approach outperforms what is currently implemented in pertpy, I could give it a shot to re-implement that approach here.

mschilli87 avatar Jun 16 '25 07:06 mschilli87