moscot

moscot copied to clipboard

To prevent low-quality results when plotting the interpolated colors in a Sankey diagram we should make the "stepsize" a variable (as opposed to 50) [here](https://github.com/theislab/moscot/blob/0a83ede4633be07859ab6b4c7336286a22581fc4/src/moscot/plotting/_utils.py#L169)

MUCDK

Currently, we get different results when doing this because of the `normalize` argument, which by default is set to `True`. Intuitively, when using push/pull on either of the two options,...

MUCDK

MUCDK

- not using `tmp_path` fixtures - simplify data regeneration - better checks using `{numpy,pandas}.testing` - parameter passing tests missing message in assert (e.g., doesn't show which key/value is wrong)

michalk8

remove generic types

1

for the sake of readability of the docs.

MUCDK

Consider using: - https://www.conventionalcommits.org/en/v1.0.0/ - https://github.com/cocogitto/cocogitto

michalk8

Consider removing `TypeVars`

michalk8

Possible options: - just a list - stick to `sphinx-gallery` - custom solution using `sphinx-design`

michalk8

This [condition](https://github.com/theislab/moscot/blob/main/src/moscot/plotting/_utils.py#L447) doesn't hold.

michalk8

There are some issues with the current approach: - [ ] all of them are regenerated, should be more granular - [ ] better path saving (someone accidentally committed in...

michalk8