cellrank icon indicating copy to clipboard operation
cellrank copied to clipboard

Feat/realtimekernel transition matrix warning

Open WeilerP opened this issue 2 years ago • 3 comments

IMPORTANT: Please search among the Pull requests before creating one.

Description

Throws an error when calculating the transition matrix with the RealtimeKernel with self_transitions provided but not conn_weight (or incorrectly) before calculating the transport maps.

How has this been tested?

Closes

Closes #875

WeilerP avatar May 26 '22 18:05 WeilerP

Codecov Report

Merging #876 (14334fb) into master (4307899) will decrease coverage by 1.51%. The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #876      +/-   ##
==========================================
- Coverage   82.20%   80.69%   -1.52%     
==========================================
  Files          70       70              
  Lines        9256     9256              
  Branches     1863     1862       -1     
==========================================
- Hits         7609     7469     -140     
- Misses       1070     1213     +143     
+ Partials      577      574       -3     
Impacted Files Coverage Δ
cellrank/external/kernels/_wot_kernel.py 23.41% <0.00%> (-65.69%) :arrow_down:
cellrank/tl/kernels/_transport_map_kernel.py 68.78% <ø> (-12.37%) :arrow_down:
cellrank/tl/kernels/_experimental_time_kernel.py 77.50% <0.00%> (-15.00%) :arrow_down:
cellrank/tl/kernels/utils/_projection.py 92.85% <0.00%> (-3.58%) :arrow_down:
cellrank/tl/estimators/_base_estimator.py 78.68% <0.00%> (-0.55%) :arrow_down:
cellrank/tl/_utils.py 71.45% <0.00%> (-0.51%) :arrow_down:
cellrank/tl/kernels/_base_kernel.py 84.09% <0.00%> (-0.25%) :arrow_down:

codecov[bot] avatar May 26 '22 18:05 codecov[bot]

@WeilerP what's the status of this PR?

michalk8 avatar Jun 14 '22 10:06 michalk8

Anything missing here?

Marius1311 avatar Jun 21 '22 12:06 Marius1311

closed in favor of #950

michalk8 avatar Oct 04 '22 10:10 michalk8