batchglm icon indicating copy to clipboard operation
batchglm copied to clipboard

Published 20 hours ago • verified publisher icon theislab

Shape Tests

Open ilan-gold opened this issue 2 years ago • 2 comments

This PR adds some tests around the shapes of implemented methods. Going to have a second pass over this because it's a bit to keep track of. This brings back up what exactly ybar is...stil not sure.

ilan-gold avatar Mar 29 '22 23:03 ilan-gold

@ilan-gold do we still need this? In my opinion, we can check all of this during model initialisation, that means during creation of an InputDataGLM object. Everything downstream is using properties from the model class so there everything should be correct. I.e. x, design_loc/scale, constraints_loc/scale, size_factors, theta_location and theta_scale are to be checked once.

picciama avatar Oct 07 '22 23:10 picciama

Are you saying we can reliably close this? I understand what you're saying, which makes sense, so we should add a check to the __init__ method? Or you're saying things would break loudly if this were wrong?

ilan-gold avatar Oct 09 '22 02:10 ilan-gold