Aayush Gupta
Aayush Gupta
It would be nice to switch to navigation3 to avoid more migration work whenever that hits stable. I will do that afterwards.
Sent a PR to add support for new plugins DSL: https://github.com/lineage-next/gradle-generatebp/pull/36
> Is it still possible to change the view between light dark and black with your changes? For me, the view no longer changes when I choose between light and...
@Gitsaibot a new review would be appreciated
> The "Primary color" setting does not work. @Gitsaibot where is this setting? Do you mean Themes?
One of the issues I am not sure why is happening is that MaterialAlertDialogs are not visible unless they are made visible by calling `show` explicitly on the dialog instance...
@Gitsaibot is Black theme and pure black color setting same thing? Edit 1: The themes and pure black color setting should be now fixed. Looking into the primary color setting.
I feel this PR is good to be merged as a base work. Not everything is pixel-perfect for sure but I feel they are minimal points and can be fixed...
> The question has nothing to do with the PR but I get this error in the Manifest.xml. Do you get that too? > > foregroundServiceType:dataSync requires permission:[android.permission.FOREGROUND_SERVICE_DATA_SYNC] Nope, I...
@Gitsaibot I have restricted pure black to only apply if you select the dark or black theme. Maybe you selected theme first then enabled pure black setting?