nanomsg.rs icon indicating copy to clipboard operation
nanomsg.rs copied to clipboard

Consider removing link-config

Open thehydroimpulse opened this issue 10 years ago • 4 comments

If we want to be compatible with the stable Rust 1.0, we won't be able to depend on or use syntax extensions, which link-config is composed of. Not to mention it's breaking every other day because of the compiler churn.

thehydroimpulse avatar Dec 22 '14 21:12 thehydroimpulse

:+1: for this. Just tried using nanomsg.rs today: https://github.com/alexcrichton/link-config/issues/18

jimfleming avatar Feb 05 '15 01:02 jimfleming

@jimfleming We have a 1.0 branch that is fully functioning right now. I'm thinking of just making that the master branch and pushing to crates.io (which removes link-config)

thehydroimpulse avatar Feb 05 '15 02:02 thehydroimpulse

Great, thanks. I'll switch to that branch for now.

jimfleming avatar Feb 05 '15 02:02 jimfleming

In this situation, we submit a PR to the link-config maintainer with the simplest fix possible, and he usually merges it in the following minute.

blabaere avatar Feb 05 '15 10:02 blabaere