littlechef-rackspace icon indicating copy to clipboard operation
littlechef-rackspace copied to clipboard

Attach block storage volumes on create

Open AMeng opened this issue 10 years ago • 6 comments

This adds the ability to attach block storage volumes when creating a node.

Volume IDs can be passed in comma separated or put into the YAML config, just like networks.

AMeng avatar Jan 07 '15 00:01 AMeng

Might want to finalize the 1.0 release before getting this in.

AMeng avatar Jan 07 '15 15:01 AMeng

+1 What say you @tildedave ?

thegreenrobot avatar Jan 07 '15 21:01 thegreenrobot

Hrm I think it will be very hard for me to evaluate this change appropriately without a Rackspace account.

tildedave avatar Jan 08 '15 03:01 tildedave

Okay so my challenge here is that I can't really know if this code is good or not because not being an employee I don't have access to easy/free infrastructure to run through my test cases. I'm certainly sure that it works for some value of your test cases but that's a bit less than my general criteria for master merge. And I guess I suck and didn't get a good enough integration testing system in place to make this sort of testing infrastructure possible without real infrastructure.

So for now my recommendation is:

  • fork repository and put whatever changes you want into there - lock your pip to that repo instead of this one
  • medium term transfer ownership of this repo to the rackerlabs org and figure out how to handle the pypi transfer as well

PS you didn't test list volumes in test_runner.py

tildedave avatar Jan 08 '15 03:01 tildedave

@tildedave, any objections to having that transfer done sooner rather than later?

According to the documentation, to transfer from an individual to an organization, we'll need to give you temporary access. Can we pick a time to do that?

As for PyPI, you can add new users to your package, under roles. I believe after you do that you can remove yourself if you want to.

Let me know how I can help with any of this.

AMeng avatar Jan 08 '15 17:01 AMeng

@thegreenrobot @tildedave @AMeng Is there anything I can help with to get this merged? Alot of flavors now default to boot from block storage.

Also did we decide if we want to transfer this repo to rackerlabs or would it be easier for them to just fork this repo?

ghost avatar Sep 03 '15 18:09 ghost