RenderTarget is affected by HDR when rendered to itself.

[thegrb93]

I never noticed since I leave HDR off, but maybe needs http://wiki.garrysmod.com/page/Enums/CREATERENDERTARGETFLAGS to fix. dunno

[thegrb93]

~~Also doesn't seem to affect gm_flatgrass~~

[h3xcat]

it does affect in gm_flatgrass Without HDR

With HDR

[thegrb93]

I'll look at it in the morning. Just finished the semester so should have some time.

[thegrb93]

I still can't reproduce it. Can I get a copy of some code to reproduce it with? (I think @Damianu gave me one, but I don't have it anymore).

[h3xcat]

Without HDR

With HDR

hdr_test.lua

[thegrb93]

I think it's because the background is pure black which makes HDR overcompensate. Look at the sky in the background, it turns white too.

[thegrb93]

I got to figure out why wire screens don't get affected this way though.

[thegrb93]

By the way, Matrix() returns an identity matrix.

[thegrb93]

I think the only difference between starfall and wiremod is they use cam.Start3D2D while starfall's uses 3D.

[h3xcat]

The render target stores the image after HDR processing. And because I reuse old render target image, it turns old pixels brighter and brighter in each frame. Wire screens don't reuse old render target images, so its not visible.

That's my guess.

[thegrb93]

So I need to modify RT textures to not do any HDR. I'll try

[thegrb93]

Not sure how. Tried this but no cigar.

GetRenderTargetEx( rtname, 1024, 1024, 
	RT_SIZE_OFFSCREEN, 
	0,  
	2048, 
	0, 
	IMAGE_FORMAT_DEFAULT 
)

I'll see if anyone replies to https://facepunch.com/showthread.php?t=1508566&p=51570474&viewfull=1#post51570474 otherwise I'll make a request in the garrysmod requests.

[thegrb93]

Okay, I've found out that this only happens when you render the rendertarget to itself.

[Damianu]

Actually it does not. For me it was enough to draw web image to renderarget and hold it in memory, then it goes darker but not full dark. When you render rendertarget to itself its more glitchy than HDR.

[thegrb93]

If I remember correctly, wire screens are affected similarly.

[thegrb93]

Going to leave it open for future reference.

[thegrb93]

If anyone wants to know the solution. Use a double buffer (i.e. two rendertargets).

[thegrb93]

There might be a material flag that can be applied to the rendertarget material to prevent this. I'm not yet willing to spend the time experimenting to test this theory yet, but it might be fixable.