thegranddesign

Results 17 comments of thegranddesign

For the record, even prior to that bad commit the indention logic was incorrect. Again, it's trying to calculate some magic number based on syntax which is incorrect. It should...

From what I gather libadwaita is only a layer on top of GTK in a way to make GTK apps consistent in look and feel. I have to say that...

Additionally I would point out that using libadwaita allows GTG to leverage changes made by the entire community rather than having to do all of that work itself. If the...

@nekohayo I'm just providing my 2 cents. I don't know Python so I can't contribute and am not doing to judge the final decisions made here. As someone who has...

Options for screen capture are implemented in #102

@rgcr thanks. :) Unfortunately I've spent way too much time on this already. I ran most of the commands against a fresh OS install of Sierra and it was about...

Additionally, some review will be needed to decide which of these commands need which process to be killed. I run this as a one time thing after a fresh OS...

@rgcr I really don't understand why you would want to remove the "dependency" of those files. You have (in the current codebase) many multiples of places where those exact things...

Just as an example: #### Before https://github.com/rgcr/m-cli/blob/ba3af98fb8be91595f8e9782a4a333c75e7d770b/plugins/finder#L27-L57 #### After ```sh hidden_files(){ value="$(_mcli_defaults_yes_no_to_boolean "com.apple.finder" \ "AppleShowAllFiles" \ "$1")" echo "${command} ${subcommand}: ${value}" } ```

@bensleveritt trying to break this up into multiple PRs is going to be a nightmare. There a ton of extraction to create the helper functions. The commits are already in...