quire icon indicating copy to clipboard operation
quire copied to clipboard

Fix/Issue-863: http check on toc image

Open rrolonNelson opened this issue 1 year ago • 2 comments

Thank you for contributing to Quire! Please complete the form below to submit your pull request for review.

For the Title of this pull request, please use the format "Type/Issue-#: Brief description." For Type, the options are Fix, Feature, Docs, or Chore. Issue-# is only needed if this pull request addresses an exisiting issue.

Checklist

Please put an X within the brackets that apply [X].

  • [X] I have read the CONTRIBUTING.md file

  • [X] I have made my changes in a new branch and not directly in the main branch

  • [X] This pull request is ready for final review by the Quire team

Is this pull request related to an open issue? If so, what is the issue number?

#863

Please briefly describe the goal of this pull request and how it may impact Quire's functionality.

This imitates the HTTP check in image-tag.js so that way we can pull an image src that has a full URL without it turning into a relative URL

Please describe the changes you made, and call out any details you think are particularly relevant for the Quire team to note in their review.

Does this pull request necessitate changes to Quire's documentation?

no

Include screenshots of before/after if applicable.

Additional Comments

I tried to get the alt text to be brought in properly as well but it doesn't seem to be working.

rrolonNelson avatar Oct 27 '23 20:10 rrolonNelson

@rrolonNelson reviewing this solution locally we discovered that the change will break images for the epub output; until we can revisit the solution, if you do not need epub output, the change in this pull-request can be made directly to a local Quire publication.

mphstudios avatar Nov 29 '23 19:11 mphstudios

change will break images for the epub output;

@rrolonNelson reviewing this solution locally we discovered that the change will break images for the epub output; until we can revisit the solution, if you do not need epub output, the change in this pull-request can be made directly to a local Quire publication.

Good catch. We are not currently using the epub. I will take another look and see if I can resolve the issue for the epub and update this PR.

rrolonNelson avatar Nov 30 '23 15:11 rrolonNelson