microstates icon indicating copy to clipboard operation
microstates copied to clipboard

Consuming lens implementation from @microstates/lens

Open taras opened this issue 5 years ago • 2 comments

In the process of building Microstates, @cowboyd wrote our own implementation of lenses. It turned out to be super tiny. I published it as a separate package available as @microstates/lens. This PR removes the local implementation in favour of the external package.

taras avatar May 02 '19 23:05 taras

I'd like to make some changes to the lens library first that I've been meaning to make for a really long time. For example, the childAt function isn't really related to the defineChildren function, and so while the former is critical to lenses, the later isn't. Been meaning to break them up for a while.

cowboyd avatar May 03 '19 23:05 cowboyd

Coverage Status

Coverage decreased (-0.09%) to 98.752% when pulling 8f70c54f301160177bbe6820815a6fd7ea116773 on tm/external-lenses into cd4114be8d9c26f4e68b520adc1380d26c9ba38a on master.

coveralls avatar May 11 '19 13:05 coveralls