interactors icon indicating copy to clipboard operation
interactors copied to clipboard

Fix pressing functional keys and add missed chars

Open wKich opened this issue 3 years ago • 4 comments

Motivation

There was problem with pressing functional keys, when instead of just sending keyDown and keyUp events the Keyboard interactor appends key code as a value to a text field

Approach

Reworked keyboard layout inspired by user-event library and added some missing chars Added list of functional keys to filter input event

wKich avatar Feb 17 '22 13:02 wKich

🦋 Changeset detected

Latest commit: d93827d3dd3d3c52f5935e2c373037e8b51942cd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@interactors/globals Patch
@interactors/keyboard Patch
@interactors/core Patch
@interactors/html Patch
@interactors/material-ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Feb 17 '22 13:02 changeset-bot[bot]

✔️ Deploy Preview for interactors canceled.

🔨 Explore the source changes: d93827d3dd3d3c52f5935e2c373037e8b51942cd

🔍 Inspect the deploy log: https://app.netlify.com/sites/interactors/deploys/622f67868414a900080fc433

netlify[bot] avatar Feb 17 '22 13:02 netlify[bot]

I just noticed that the keys were going into the globals package. Why is that required? The reason I ask is that I believe we want to keep the globals as slim as possible.

cowboyd avatar Mar 14 '22 09:03 cowboyd

Yeah, we can move non-printable keys set out to the keyboard package

wKich avatar Mar 14 '22 15:03 wKich