ember-let Helpers are re-computed too many times in Glimmer 2 when using passed into let

Oct 12 '16 15:10 taras

Since I can't see the failure mode in CI (due to Phantom not supporting Object.assign), can you describe what is failing? What Ember versions?

Also, in general, the helper in this example is pretty complicated and makes the test much harder to read. If the failure scenario can be isolated further (i.e. if it only needs a simple recompute call) we should do that.

Oct 12 '16 15:10 rwjblue

@rwjblue I updated the tests and you can see the failing behaviour https://travis-ci.org/thefrontside/ember-let/jobs/167131308#L362

@cowboyd I'm working on simplifying the test by explicitly calling recompute and moving side effects into beforeEach.

Oct 12 '16 18:10 taras

Is the failure you are talking about basically that the helper's compute is called more times than you expect on Ember beta and canary? If yes, I highly doubt the fault lies with ember-let.

See the following for background context:

https://github.com/emberjs/ember.js/pull/14410
https://github.com/emberjs/ember.js/issues/14335

Oct 12 '16 18:10 rwjblue

Can we update this to check against current beta/canary builds? A bunch of update tracking changes landed upstream, and I'm curious if that fixed the failing test...

Nov 01 '16 15:11 rwjblue

Ok, I'll look into it today.

Nov 01 '16 16:11 taras

@rwjblue just tested against 2.10.0-beta.2-beta+06892432 and got same failures.

Nov 01 '16 16:11 taras