ember-let icon indicating copy to clipboard operation
ember-let copied to clipboard

We need AST transform tests

Open taras opened this issue 8 years ago • 2 comments

I've been experimenting with inline let and it behaves unpredictably. There could be something wrong with the AST transform code. We need to add node tests for it.

taras avatar Sep 23 '16 18:09 taras

They will just be super brittle. We need to focus on testing the things we care about, which in this case is whatever thing at runtime that you noticed was wrong.

rwjblue avatar Sep 23 '16 19:09 rwjblue

Do you have an example? The AST transform is fairly straightforward and only touches stable parts of the AST so I would be surprised if it broken in any version. It seems more likely that helper runtime code is malfunctioning.

mmun avatar Sep 30 '16 17:09 mmun