forklift icon indicating copy to clipboard operation
forklift copied to clipboard

Drop CentOS 8 stream box

Open archanaserver opened this issue 1 year ago • 9 comments

https://github.com/theforeman/forklift/issues/1824

  • [x] https://github.com/theforeman/forklift/pull/1841
  • [x] https://github.com/theforeman/forklift/pull/1842
  • [x] https://github.com/theforeman/forklift/pull/1843
  • [ ] https://github.com/theforeman/forklift/pull/1844
  • [ ] https://github.com/theforeman/forklift/pull/1845
  • [ ] https://github.com/theforeman/forklift/pull/1846

archanaserver avatar Jun 06 '24 10:06 archanaserver

Test failures are related. You'll also need to remove all references to the centos8-stream box.

Would you mind expanding it a little more, might be I'm missing something here.

While you're at it, perhaps also drop the centos8 box because CentOS Linux 8 has been EOL for much longer.

@ekohl Also for the devel box update to alma here: https://github.com/theforeman/forklift/blob/master/vagrant/boxes.d/99-local.yaml.example do we want to update to centos9-stream but also add alma8 or 9 there or only alma update? Like here(https://github.com/theforeman/forklift/pull/1820) they are trying to do both for katello boxes and I can't understand.

archanaserver avatar Jun 06 '24 11:06 archanaserver

Ah I just saw what I ask is already fixed in here https://github.com/theforeman/forklift/pull/1820#issuecomment-2152862825

archanaserver avatar Jun 07 '24 07:06 archanaserver

@ekohl would you mind reviewing the recent changes once?

archanaserver avatar Jun 12 '24 04:06 archanaserver

@ekohl i'm not quite sure about the changes i have made here, would you mind looking it :/

archanaserver avatar Jun 24 '24 20:06 archanaserver

I suppose we should also drop CentOS 7 boxes as well?

ehelms avatar Jun 27 '24 13:06 ehelms

I'm debating the katello_devel test pipeline. AFAIK it's been broken for a long time and in theforeman/jenkins-jobs@44ddb48 (2022) we dropped the pipeline. Perhaps just get rid of the code as well?

Since it has been broken and dropped, i believe it make sense to remove the code. i've updated the PR.

Then as @ehelms suggested, do the same for centos7. Perhaps in this PR, perhaps in a separate.

I also suggested we can drop some old versions.

Also #1832

archanaserver avatar Jul 12 '24 13:07 archanaserver

Ansible part LGTM, didn't look at the rest.

evgeni avatar Jul 18 '24 12:07 evgeni

@ekohl does it looks good? i'll try splitting it on separate PR after that.

archanaserver avatar Aug 09 '24 06:08 archanaserver

Could you submit things as separate PRs? Where one depends on another you can wait with submitting it. I at least think that the katello_devel pipeline drop is incomplete, because in 264a2bf you update a config file for that pipeline. If you drop a pipeline, it also doesn't need any configuration anymore.

@ekohl i've tried splitting the work in separate PRs, https://github.com/theforeman/forklift/pull/1841 depends on rest, we can look on this first. i'll add rest of the PRs in draft as if now, will update things once we start merging things.

archanaserver avatar Aug 20 '24 05:08 archanaserver

All changes are merged check https://github.com/theforeman/forklift/pull/1826#issue-2337883188, so closing this one.

archanaserver avatar Sep 21 '24 03:09 archanaserver