foreman_remote_execution icon indicating copy to clipboard operation
foreman_remote_execution copied to clipboard

Only package a static list of files

Open ekohl opened this issue 1 year ago • 1 comments

This copies the static list of files from the plugin template. It avoids calling git, which means it works in more environments, but it can cause local files not tracked in git to be included. test_files is avoided because it's deprecated.

Primary motivation was packit builds where we temporarily need to include gemfile.d to test against another PR, but don't want that to show up in the final packit RPMs.

ekohl avatar Jun 24 '24 15:06 ekohl

Looks like we need to remove the files from the spec file too:

error: File not found: /builddir/build/BUILDROOT/rubygem-foreman_remote_execution-13.2.1-1.20240624154646537200.pr908.1.gbcd1648.el9.x86_64/usr/share/gems/gems/foreman_remote_execution-13.2.1/Gemfile
error: File not found: /builddir/build/BUILDROOT/rubygem-foreman_remote_execution-13.2.1-1.20240624154646537200.pr908.1.gbcd1648.el9.x86_64/usr/share/gems/gems/foreman_remote_execution-13.2.1/foreman_remote_execution.gemspec
error: File not found: /builddir/build/BUILDROOT/rubygem-foreman_remote_execution-13.2.1-1.20240624154646537200.pr908.1.gbcd1648.el9.x86_64/usr/share/gems/gems/foreman_remote_execution-13.2.1/test
    File not found: /builddir/build/BUILDROOT/rubygem-foreman_remote_execution-13.2.1-1.20240624154646537200.pr908.1.gbcd1648.el9.x86_64/usr/share/gems/gems/foreman_remote_execution-13.2.1/jsconfig.json
    absolute symlink: /usr/share/foreman/public/assets/foreman_remote_execution -> /usr/share/gems/gems/foreman_remote_execution-13.2.1/public/assets/foreman_remote_execution
    absolute symlink: /usr/share/foreman/public/webpack/foreman_remote_execution -> /usr/share/gems/gems/foreman_remote_execution-13.2.1/public/webpack/foreman_remote_execution
    File not found: /builddir/build/BUILDROOT/rubygem-foreman_remote_execution-13.2.1-1.20240624154646537200.pr908.1.gbcd1648.el9.x86_64/usr/share/gems/gems/foreman_remote_execution-13.2.1/Gemfile
    File not found: /builddir/build/BUILDROOT/rubygem-foreman_remote_execution-13.2.1-1.20240624154646537200.pr908.1.gbcd1648.el9.x86_64/usr/share/gems/gems/foreman_remote_execution-13.2.1/foreman_remote_execution.gemspec
    File not found: /builddir/build/BUILDROOT/rubygem-foreman_remote_execution-13.2.1-1.20240624154646537200.pr908.1.gbcd1648.el9.x86_64/usr/share/gems/gems/foreman_remote_execution-13.2.1/test

ekohl avatar Jun 24 '24 15:06 ekohl

Let's go with this and figuring out the packaging later. Could you please undraft?

adamruzicka avatar Oct 29 '24 08:10 adamruzicka

Thank you @ekohl !

adamruzicka avatar Nov 06 '24 12:11 adamruzicka