foreman_openscap
foreman_openscap copied to clipboard
theforeman
WIP: Fix "SCAP Content" menu entry
- Converts the "SCAP Content" menu entry to title case.
- Converts the uncountable noun "Content" to singular.
Relates to: https://projects.theforeman.org/issues/25223
The reason it is "WIP" is that converting the term "Content" to singular means that certain paths and variables should also be changed. This is more involved and needs more testing, that I have not yet gotten around to...
Thanks for the patch, while we're on topic, what do you think about extracting the whole menu to first level category?
Does "first level category" mean that Open SCAP would have its own menu next to "Monitor", "Content", "Hosts", "Configure", etc. ? If so, I don't have any particularly strong opinions on that. I do feel like the menu path Hosts > Compliance > Reports, would fit more naturally under Monitor > Reports > Compliance. On the other hand, I am hesitant to spread out the Open SCAP plugin's menu entries all over the UI. Perhaps there needs to be a general discussion whether plugins should keep their menu entries together or whether they should be spread around by topic. (As another example, I hate the fact that Katello "Content Hosts" are in the "Hosts" menu and not in the "Content" menu, imho it makes for a really awkward workflow.)
Perhaps we should really open a discussion on discourse. I feel like my previous comment goes beyond the scope of a PR. :smile:
Perhaps we should really open a discussion on discourse. I feel like my previous comment goes beyond the scope of a PR. 😄
@quba42 Hi, sorry for doing a bit of a repo archeology and poking into old things, but was there such a discussion?
@adamruzicka If I did not link such a discussion here, then no, it probably did not happen.