foreman_maintain icon indicating copy to clipboard operation
foreman_maintain copied to clipboard
verified publisher icon theforeman

Factor out the target version to a method

Open ekohl opened this issue 2 years ago • 2 comments

This allows copying the scenario without having to modify the target version everywhere. Ideally more steps would be taken out and reused.

This should probably be applied to many files, but first I'd like to get approval on the idea before I put in too much effort only to have to redo it.

ekohl avatar Jan 04 '23 12:01 ekohl

I think Rubocop gets confused by the complex ways to define classes. There's some heavy meta-programming going on.

ekohl avatar Jan 04 '23 13:01 ekohl

I think this is a good change, https://github.com/theforeman/foreman_maintain/pull/705 means we won't have to make it in but a few extra places.

ehelms avatar Mar 31 '23 17:03 ehelms

This is being addressed through various changes, in large, culminating through https://github.com/theforeman/foreman_maintain/pull/879

ehelms avatar Jun 13 '24 18:06 ehelms