foreman icon indicating copy to clipboard operation
foreman copied to clipboard

Fixes #37043 - Inheritance overrides host facets

Open ananace opened this issue 1 year ago • 6 comments

ananace avatar Jan 11 '24 15:01 ananace

Will this affect the behavior of https://github.com/Katello/katello/pull/10841 ?

cc @parthaa @qcjames53

jeremylenz avatar Jan 16 '24 14:01 jeremylenz

I'm not entirely sure to be honest. My hunch is we should be ok since I'm removing the apply_inherited_attributes method from Katello entirely. Once I finish up the new unit tests I'll run this PR through to see if anything breaks.

qcjames53 avatar Jan 22 '24 14:01 qcjames53

@shimshtein

ananace avatar Feb 05 '24 17:02 ananace

Redid merge code and added tests for both overriding with an actual value as well as with nil.

I don't know if the merge result will be exactly as expected with every potential mix of strings/symbols, but I wasn't able to make it misbehave in the tests, so I decided to skip slapping with_indifferent_access on everything.

ananace avatar Feb 14 '24 16:02 ananace

@qcjames53 were you able to finish the unit tests? I would like to run this PR there just to be sure I am not missing some use case.

Otherwise LGTM.

ShimShtein avatar Feb 15 '24 10:02 ShimShtein

Hey @ShimShtein. The changes are merged into master branch Katello; you should be all good to go.

qcjames53 avatar Feb 15 '24 20:02 qcjames53

[test katello]

jeremylenz avatar Mar 11 '24 13:03 jeremylenz

Merged, thanks @ananace !

ShimShtein avatar Mar 11 '24 13:03 ShimShtein