foreman
foreman copied to clipboard
Fixes #37043 - Inheritance overrides host facets
Will this affect the behavior of https://github.com/Katello/katello/pull/10841 ?
cc @parthaa @qcjames53
I'm not entirely sure to be honest. My hunch is we should be ok since I'm removing the apply_inherited_attributes
method from Katello entirely. Once I finish up the new unit tests I'll run this PR through to see if anything breaks.
@shimshtein
Redid merge code and added tests for both overriding with an actual value as well as with nil
.
I don't know if the merge result will be exactly as expected with every potential mix of strings/symbols, but I wasn't able to make it misbehave in the tests, so I decided to skip slapping with_indifferent_access
on everything.
@qcjames53 were you able to finish the unit tests? I would like to run this PR there just to be sure I am not missing some use case.
Otherwise LGTM.
Hey @ShimShtein. The changes are merged into master branch Katello; you should be all good to go.
[test katello]
Merged, thanks @ananace !