Fixes #37429 - update theforeman-rubocop gem

[archanaserver]

for reference: https://github.com/theforeman/theforeman-rubocop/pull/8#issuecomment-1825840790

Updated this after working on series of cops fixes:

• [ ] https://github.com/theforeman/foreman/pull/9926
• [x] https://github.com/theforeman/foreman/pull/9977
• [ ] https://github.com/theforeman/foreman/pull/10257
  • [x] https://github.com/theforeman/foreman/pull/10051
• [x] https://github.com/theforeman/foreman/pull/10080
  • [x] https://github.com/theforeman/foreman/pull/10063
  • [x] https://github.com/theforeman/foreman/pull/10064
  • [x] https://github.com/theforeman/foreman/pull/10065
  • [x] https://github.com/theforeman/foreman/pull/10258
  • [x] https://github.com/theforeman/foreman/pull/10067
  • [x] https://github.com/theforeman/foreman/pull/10068
  • [x] https://github.com/theforeman/foreman/pull/10071
  • [x] https://github.com/theforeman/foreman/pull/10073
  • [x] https://github.com/theforeman/foreman/pull/10072

[ekohl]

I would start with fixing up the minitest cops and submit those as a PR. That will trim this down, but also work in develop.

[archanaserver]

@ekohl I was trying to run bundler but throwing this error, I can't continue because I can't understand why it is talking about foreman-admin dir here even though i'm in the right one? Would you mind taking a look here?

[!] There was an error parsing `Gemfile`: There are no gemspecs at /home/akumari/Desktop/foreman-admin. Bundler cannot continue.

 #  from /home/akumari/Desktop/foreman/Gemfile:56
 #  -------------------------------------------
 #  Dir["#{File.dirname(FOREMAN_GEMFILE)}/bundler.d/*.rb"].each do |bundle|
 >    instance_eval(Bundler.read_file(bundle))
 #  end
 #  -------------------------------------------

[ekohl]

Check if there's anything in your local bundler files: grep foreman-admin bundler.d/*

[archanaserver]

Check if there's anything in your local bundler files: grep foreman-admin bundler.d/*

Got it, Thanks!

also @ekohl, how can we handle this Rubocop failed offenses, i can see this is a lot.

[ekohl]

also @ekohl, how can we handle this Rubocop failed offenses, i can see this is a lot.

In my experience it's best to look at them one by one. RuboCop has --only to do that. Then there are also cops which change a lot of code, like Layout. So I'd first focus on Minitest/*

[stejskalleos]

@archanaserver can you please rebase over the latest develop?

[archanaserver]

@stejskalleos Now this need a long list of RuboCop fix, I have raised PR for Minitest/ and Layout/:

• [ ] https://github.com/theforeman/foreman/pull/9977
• [ ] https://github.com/theforeman/foreman/pull/9982

I posted something related to my Layout/ArgumentAlignment cops fixes issue I'm facing, https://community.theforeman.org/t/rubocop-changes-in-foreman-input-needed/36950