foreman
foreman copied to clipboard
Fixes #35817 - Avoid using fixtures for test settings
When running rake snapshots:generate it doesn't load the fixtures. This normally happens in the test setup code, but snapshot generation doesn't use this. This patch uses the settings DSL to set a different default depending on the environment. An additional benefit is that the code is more localized.
Issues: #35817
Both of the failures are about the setting table being empty IMHO. One of them easily fixable by just creating the setting tho I'm not sure how to fix the uniqueness test.
This mixes test code with production code, which I'm generally against, but the benefits you're describing are outweighing the cons here so :+1:
Thank you for your contribution, @ekohl! This PR has been inactive for 3 months, closing for now. Feel free to reopen when you return to it. This is an automated process.
Reopening the PR, I'm still having the problem on the develop branch. @ekohl can you please rebase the PR?
I think I've got work blocked waiting for this PR
Thank you for your contribution! This PR has been inactive for 3 months, closing for now. Feel free to reopen when you return to it. This is an automated process.