foreman icon indicating copy to clipboard operation
foreman copied to clipboard

Fixes #35497 - New host UI - Link to host group

Open stejskalleos opened this issue 2 years ago • 5 comments

Screenshot from 2022-09-07 14-26-09

stejskalleos avatar Sep 07 '22 12:09 stejskalleos

Issues: #35497

theforeman-bot avatar Sep 07 '22 12:09 theforeman-bot

I haven't tested but would like to ask, what does it do when a user does not have a permission to view that host group?

ares avatar Sep 08 '22 14:09 ares

I haven't tested but would like to ask, what does it do when a user does not have a permission to view that host group?

After user clicks on the edit icon he's redirected to the host group edit page with permission denied error

@MariaAga I updated PR however I failed with the styling of components, https://marvelapp.com/prototype/995cc27/screen/77850645 shows design but I wasn't able to do it with PF4, I couldn't even make the icon in different color, docs for it shows some variables but I have no idea how to implement it. Do we have any source code sample somewhere?

stejskalleos avatar Sep 14 '22 07:09 stejskalleos

For the edit button, the variant should be variant="plain" instead of a link to fix the color. Also the button should not be shown if there is no host group Screenshot from 2022-09-14 09-57-29

MariaAga avatar Sep 14 '22 07:09 MariaAga

Icon & empty state fixed

stejskalleos avatar Sep 15 '22 07:09 stejskalleos

Sorry, just noticed now that in the design the pencil is aligned to the right, other than that everything is working as it should

fixed

stejskalleos avatar Sep 22 '22 10:09 stejskalleos