foreman icon indicating copy to clipboard operation
foreman copied to clipboard

Deprecate Foreman::Cast.to_bool

Open Dyrkon opened this issue 2 years ago • 7 comments

Deprecate Foreman::Cast.to_bool method.

Dyrkon avatar Aug 30 '22 07:08 Dyrkon

Can one of the admins verify this patch?

theforeman-bot avatar Aug 30 '22 07:08 theforeman-bot

Can one of the admins verify this patch?

theforeman-bot avatar Aug 30 '22 07:08 theforeman-bot

Can one of the admins verify this patch?

theforeman-bot avatar Aug 30 '22 07:08 theforeman-bot

Issues: #34424

theforeman-bot avatar Aug 30 '22 07:08 theforeman-bot

ok to test

adamruzicka avatar Aug 30 '22 07:08 adamruzicka

just FYI there is piece of offline discussion missing in https://github.com/theforeman/foreman/pull/9079#discussion_r796700058. I was saying we could switch to the rails behaviour, because I doubt we are relying on the weird behaviour of Cast::to_bool, but they are behaving differently so we need to think about it case by case IMHO.

But thanks a bunch for doing this! :orange_heart:

ezr-ondrej avatar Aug 30 '22 07:08 ezr-ondrej

@Dyrkon one more thing, we should also check plugins if they use Foreman::Cast.to_bool, and replace it it there too

stejskalleos avatar Sep 06 '22 10:09 stejskalleos