foreman
foreman copied to clipboard
Deprecate Foreman::Cast.to_bool
Deprecate Foreman::Cast.to_bool method.
Can one of the admins verify this patch?
Can one of the admins verify this patch?
Can one of the admins verify this patch?
Issues: #34424
ok to test
just FYI there is piece of offline discussion missing in https://github.com/theforeman/foreman/pull/9079#discussion_r796700058. I was saying we could switch to the rails behaviour, because I doubt we are relying on the weird behaviour of Cast::to_bool
, but they are behaving differently so we need to think about it case by case IMHO.
But thanks a bunch for doing this! :orange_heart:
@Dyrkon one more thing, we should also check plugins if they use Foreman::Cast.to_bool
, and replace it it there too