foreman Fixes #35432 - Use Rails 6.1 defaults

Rails has introduced config.load_defaults to load the defaults of a certain version. Currently this is not called at all, which means using Rails < 5.0 defaults. Changing this brings Foreman more in line with the Rails recommended defaults.

Right now this is a draft since I'm a bit uncertain of all the implications.

Aug 25 '22 12:08 ekohl

Issues: #35432

Aug 25 '22 12:08 theforeman-bot

Quite certain test failures are related. Will need to dive into them.

Aug 25 '22 12:08 ekohl

I've split it into multiple commits so I can dive into it and see where things break. Currently running tests on these.

Aug 25 '22 13:08 ekohl

Rebased on #9332 now. Still need to dive into the failures.

Sep 05 '22 14:09 ekohl

For encryption I think it the requirements on the key may have been tightened. The key looks to be md5 (they are always 32 characters): https://github.com/theforeman/foreman/blob/06600bcca9025390a004413700deda4fa601837e/test/unit/encryptable_test.rb#L17 Perhaps updating this to a stronger key is sufficient.

As for the interface validation errors, I don't know. I wish the errors were less vague.

Sep 09 '22 10:09 ekohl

Thank you for your contribution, @ekohl! This PR has been inactive for 3 months, closing for now. Feel free to reopen when you return to it. This is an automated process.

Dec 10 '22 01:12 theforeman-bot

Thank you for your contribution, @ekohl! This PR has been inactive for 3 months, closing for now. Feel free to reopen when you return to it. This is an automated process.

Mar 12 '23 01:03 theforeman-bot