foreman icon indicating copy to clipboard operation
foreman copied to clipboard

Fixes #35287 - Create column selector on host index page

Open pkoprda opened this issue 3 years ago • 3 comments

User should be able to specify what columns wants to see on host index page. This approach using PF4 Selector hopefully can be applied for other index pages in the future.

Depends on #9319

pkoprda avatar Jul 26 '22 15:07 pkoprda

Issues: #35287

theforeman-bot avatar Jul 26 '22 15:07 theforeman-bot

Also, there is a conflict now :/

ofedoren avatar Aug 22 '22 21:08 ofedoren

When I try to save my selection, nothing happens and I get this in the browser console. What am I doing wrong? image

adamruzicka avatar Sep 15 '22 12:09 adamruzicka

Adding some screenshots: selectable-columns-screenshot-1 selectable-columns-screenshot-2


@MariSvirik any thoughts on this?

pkoprda avatar Oct 04 '22 12:10 pkoprda

@pkoprda I would just copy what we have in PF4. Can I see somewhere this implementation and click through it?

Table

  1. First of all, I would go with "Manage filters" copy instead of "Filter columns".
  2. The button should be closer to the end of the search bar: 16 px spacing between those two
  3. The button should be either a link button (without a box around it) as in the PF4 example or a secondary button.

Modal

  1. add a description: e.g. "Select columns to display in the table." Otherwise, I'm not sure what is happening there.
  2. The position of the modal should be fixed even when the rows collapse. Otherwise, it's super annoying.
  3. Based on your example I can clear out the entire table. We should have some default columns that you can't hide e.g. Name.

MariSvirik avatar Oct 05 '22 13:10 MariSvirik

@ofedoren please don't squash commits unless that's really what you want. We generally use the rebase option to merge.

ekohl avatar Nov 23 '22 15:11 ekohl