foreman icon indicating copy to clipboard operation
foreman copied to clipboard

Fixes #35137 Permit setting puppet tag during install

Open jcpunk opened this issue 3 years ago • 1 comments

This lets folks override the tags selected for puppet runs.

jcpunk avatar Jun 29 '22 14:06 jcpunk

Issues: #35137

theforeman-bot avatar Jun 29 '22 14:06 theforeman-bot

The change makes sense to me, but you'd have to re-record the snapshots of the rendered templates.

Please ping if you need any help with that :)

evgeni avatar Aug 19 '22 06:08 evgeni

I fear my dev box is running fedora with a version of ruby that errors out when I try to regenerate the templates for the tests......

On Fri, Aug 19, 2022, 2:48 AM Evgeni Golov @.***> wrote:

The change makes sense to me, but you'd have to re-record the snapshots of the rendered templates.

Please ping if you need any help with that :)

— Reply to this email directly, view it on GitHub https://github.com/theforeman/foreman/pull/9285#issuecomment-1220314532, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA2673VE3ZUYMYPX7WVVMMDVZ4U47ANCNFSM52GBTBOA . You are receiving this because you authored the thread.Message ID: @.***>

jcpunk avatar Aug 19 '22 13:08 jcpunk

@evgeni it looks like all my dev boxes either have a ruby that is too new or too old... I fear I don't seem to have one that is "just right"...

jcpunk avatar Aug 22 '22 21:08 jcpunk