foreman
foreman copied to clipboard
theforeman
Pf4 autocomplete
depends on https://github.com/theforeman/foreman/pull/9186 This pr will break remote execution plugin. The component is based on this demo: https://www.patternfly.org/v4/components/search-input/react-demos
@Ron-Lavi This is ready now :partying_face:
Also fixed a bug where users will go to audits?page=1&per_page&search=os++%3D++CentOS+ (or any search) and the search bar was empty
@Ron-Lavi Fixed the tests. app/assets/javascripts/filters.js was removed because it was part of the old filters page and using autocomplete actions
Thanks for the review! I can add a search on clicking the clear button, but it will be a sudden change for users that are used for it just deleting the text. also in a lot of pages it will reload the whole page which might get annoying if users only wanted to type something different.
Maybe adding searchOnClear bool option for the search?
I can add a search on clicking the clear button, but it will be a sudden change for users that are used for it just deleting the text.
There are two interactions here -
When I've executed a search already, and I'm viewing search results, and the search input is unaltered (still displaying my search text), and I haven't changed the text - then clicking the X should execute an empty search.
When I've typed something / changed the search input, but I haven't clicked our beautiful new right arrow submit button - then clicking the X should just clear the search input and not execute an empty search.
cc @MariSvirik
I think the clear button should only do one action per page, either deleting or searching, but both are even more confusing
If that's what we end up deciding I guess that's okay. But we will have to change Katello search to match that. Needs some more discussion.
There are two interactions here -
When I've executed a search already, and I'm viewing search results, and the search input is unaltered (still displaying my search text), and I haven't changed the text - then clicking the X should execute an empty search.
When I've typed something / changed the search input, but I haven't clicked our beautiful new right arrow submit button - then clicking the X should just clear the search input and not execute an empty search.
Isn't this what we decided to do last week? ... to follow console dot? And also to change everything that can be changed in Satellite accordingly? That's how the cancel button works in the console dot (more or less. Even though the console triggers a search on inactivity when there is an input). Maybe let's consider X to be ' Reset' - clearing the search field and going back to the default state of the table rather than either searching or deleting. Does this make sense? @jeremylenz @MariaAga
