Fixes #34764 - refactor filters page

[MariaAga]

Kept it the same expect removed tabs so the orgs and loations selectors will be in the same form old: new:

[theforeman-bot]

Issues: #34764

[MariaAga]

@Ron-Lavi Can you take a look? :)

[ares]

Wow, that looks cool! could you also share a screen shot of a model, that supports taxonomies? The only design note I'd have - the width of the dropdowns seems too much, we got such feedback in the registration form too, it should not span to 100% I guess.

[MariaAga]

Thanks @ares! Technically the select width is max 880px so it wont be the full width in wide screens. And there is no other pf guideline that I know of. for simplicity the orgs and locations are on the same page:

[MariaAga]

@Ron-Lavi - Thanks, fixed some of the failing tests, the rest look unrelated

[Ron-Lavi]

@MariaAga can you rebase, tests should be fixed now via #9302

[Ron-Lavi]

@MariaAga can you rebase?

[MariaAga]

@Ron-Lavi Rebased, test failures dont look related

[MariaAga]

test failure related, fixing

Failure:

[2022-07-26T09:09:54.353Z] AccessPermissionsTest#test_0289_route permissions/index should have a permission that grants access [/home/jenkins/workspace/foreman-pr-katello-test/foreman/test/unit/shared/access_permissions_test_base.rb:33]

[2022-07-26T09:09:54.353Z] Minitest::Assertion: permission for permissions/index not found, check access_permissions.rb.

[2022-07-26T09:09:54.353Z] Expected [] to not be empty.

[MariaAga]

@Ron-Lavi fixed the test failure

[MariaAga]

@adamruzicka any more things needed in this pr?

[adamruzicka]

Nope, looks good to me, although we should probably hold this until stabilization is over?

[MariaAga]

do not merge- this issue is still not resolved, fixing https://github.com/theforeman/foreman/pull/9186#discussion_r848642390

[MariaAga]

The above issue is resolved

[adamruzicka]

Noticed one more thing. When I go to edit an already existing filter, it still allows me to select a different role for it in the first dropdown. However if I do so, I get 422 on submit. Could we disable that field on edit?

[MariaAga]

Thanks @adamruzicka! fixed, could you take a look at the ruby part? the issue was that the locked roles are shown in the dropdown, but users cant really edit them because they are locked. I also made the toaster sticky with a more clear message in case there would be more "backend is not happy" issues