theforeman
Fixes #38916 - Update EditorHostSelect to pf5
I tried to replicate the behavior of https://v5-archive.patternfly.org/components/menus/select/#typeahead as much as possible, but that means that there are some differences from the pf3 EditorHostSelect. First host is no longer automatically used for preview. This can be easily reverted if desired.
Issues
- I haven't been able to fix the bottom margin of the Select after several attempts of inserting padding into various places. Any ideas how can I fix that?
Questions
- How do we want to handle the case when hostname does not fit into the EditorHostSelect? I thought about adding a tooltip or making the font smaller.
I didnt read the code yet, but isnt
replicate the behavior of https://v5-archive.patternfly.org/components/menus/select/#typeahead
The same as this pr? https://github.com/theforeman/foreman/pull/10734
I didnt read the code yet, but isnt
replicate the behavior of https://v5-archive.patternfly.org/components/menus/select/#typeahead
The same as this pr? #10734
@MariaAga mostly the same but EditorHostSelect has some extra properties and I don't really know whether adjusting AutocompleteInput to replace EditorHostSelect won't break the use of AutocompleteInput in other places.
Took a brief look at the changes and also at airgun:
- I see editor-select-container stayed as an ID, which is great but I don't see it referenced in airgun anyway -- that's probably something to be changed, but this fact tells me that the tests doing template preview rely on the first host prefill, so in that matter this will definitely be a breaking change for ds tests. I'd like you to consider getting back to the fist item prefill, I think it was a nice click saver for users
- the padding issue is definitely a problem for me, imho its ok to make the navbar thicker if we cant make the dropdown thinner
- also I'd add some definition to the dropdown border, I imagine it would be hard to read, or maybe if it was with white background, not gray on gray
