foreman icon indicating copy to clipboard operation
foreman copied to clipboard

Use WF to label PRs breaks-robottelo on comment

Open lhellebr opened this issue 7 months ago • 2 comments

This is a workflow that uses https://github.com/theforeman/actions/pull/69 to add breaks-robottelo label to a PR when a comment /label breaks-robottelo is added to it.

Reason:

In my team, we've identified a problem: often, a PR breaks our tests, be it an API change, UI change, or whatever not-that-important change that gives QE hard time in the process of finding a failure, identifying a change, investigating whether the change was intended and fixing the test in Robottelo. Most often, it seems, this is caused by WebUI locators changes. We have proposed this solution: there will be an optional label for foreman and foreman-plugin repos that developers should set when they expect some change will break tests, especially WebUI. The QEs then should prefer to look at these PRs to change the tests before they get broken.

lhellebr avatar Jun 11 '25 12:06 lhellebr

To make this work:

  1. merge the actions PR
  2. add a breaks-robottelo label in the repo
  3. merge this PR

After it is merged, I'll open similar PRs against other theforeman repos as well

lhellebr avatar Jun 11 '25 12:06 lhellebr

Guidelines: https://github.com/theforeman/theforeman.org/pull/2234

lhellebr avatar Jun 11 '25 23:06 lhellebr

Bump @MariaAga @ekohl

lhellebr avatar Jul 09 '25 14:07 lhellebr

  1. Actions PR merged

lhellebr avatar Jul 22 '25 14:07 lhellebr

/label breaks-robottelo

lhellebr avatar Sep 24 '25 16:09 lhellebr

@evgeni you merged this PR without first creating a new label "breaks-robottelo" in this repo. The action can't add a label to a PR that isn't first manually added to the repo.

lhellebr avatar Sep 24 '25 16:09 lhellebr

🤷‍♀️

I was only asked to merge it ;)

evgeni avatar Sep 24 '25 16:09 evgeni

/label breaks-robottelo

lhellebr avatar Sep 24 '25 16:09 lhellebr