foreman icon indicating copy to clipboard operation
foreman copied to clipboard

Fixes #38435 - remove select2 tooltips

Open MariaAga opened this issue 7 months ago • 9 comments

Removed the work arounds to try to make the tooltips works removed all tooltips sometimes they are re-added when a select happens (sometimes because a new part of the page is added), so also remove them on select. It breaks tests randomly with no way to fix them otherwise

MariaAga avatar May 21 '25 11:05 MariaAga

Is there a way we could drop the select2 dependency altogether? Any idea how many select2 tooltips we have in our codebase(s)?

ekohl avatar May 21 '25 11:05 ekohl

I dont see how, as just updating it was such a pain, replacing it and keeping the functionality in all different uses and plugins will be very difficult. the tooltips are added by select2 to the clear button, and to the select2 result bar/span

MariaAga avatar May 21 '25 11:05 MariaAga

image

MariaAga avatar May 21 '25 11:05 MariaAga

I dont see how, as just updating it was such a pain, replacing it and keeping the functionality in all different uses and plugins will be very difficult.

I see it is indeed used widely. I'd like to hear your thoughts on how to remove it. Do we have a replacement? If so, can we at least deprecate it for us developers?

ekohl avatar May 21 '25 11:05 ekohl

how to remove it - probably by replacing all .html.erb to react, otherwise were working hard on a code that we will delete later anyway

MariaAga avatar May 21 '25 11:05 MariaAga

I fear you're right.

ekohl avatar May 21 '25 12:05 ekohl

I had the integration test in foreman_puppet running against this PR as this is where it popped up and now it works just fine :+1:

nadjaheitmann avatar May 21 '25 12:05 nadjaheitmann

Is there anything preventing this one from being merged? Would love to have the foreman_puppet CI to be green again :)

nadjaheitmann avatar Jun 03 '25 09:06 nadjaheitmann

currently they disappear if hovered more than once so they are barely there?

MariaAga avatar Jun 10 '25 14:06 MariaAga