Fixes #37647 - Make telemetry allowed_labels configurable
It might not be the best idea to put the lengthy list of classes to settings.yaml. As the list contains majority of classes either way, maybe we can have there simply:
:class:
- '.*'
?
I think we shouldn't require those values to always be present in
settings.yamlbut rather have a hard coded default. We do that in config/settings.rb.
Good point. And we should allow to configure either :controller or :action or :class independently. Like allow in config:
:allowed_labels:
:class:
- '.*'
that will update just the classes.
I will update PR accordingly.
I think the failing test:functionals are independent on my PR.
Correct, I just restarted those tests because it should have been fixed.