foreman icon indicating copy to clipboard operation
foreman copied to clipboard

Fixes #37647 - Make telemetry allowed_labels configurable

Open pmoravec opened this issue 1 year ago • 3 comments

It might not be the best idea to put the lengthy list of classes to settings.yaml. As the list contains majority of classes either way, maybe we can have there simply:

:class:
 - '.*'

?

pmoravec avatar Jul 14 '24 15:07 pmoravec

I think we shouldn't require those values to always be present in settings.yaml but rather have a hard coded default. We do that in config/settings.rb.

Good point. And we should allow to configure either :controller or :action or :class independently. Like allow in config:

:allowed_labels:
  :class:
   - '.*'

that will update just the classes.

I will update PR accordingly.

pmoravec avatar Jul 15 '24 14:07 pmoravec

I think the failing test:functionals are independent on my PR.

pmoravec avatar Jul 16 '24 19:07 pmoravec

Correct, I just restarted those tests because it should have been fixed.

ekohl avatar Jul 18 '24 10:07 ekohl