Fixes #37390 - drop jquery-ui

Open MariaAga opened this issue 1 year ago • 4 comments

Last use was in https://github.com/theforeman/foreman/commit/b55d3ed74669e8b0e6f5027df98da38f10cf0ed2 didnt find any other use for the jquery-ui js or css

Apr 26 '24 17:04 MariaAga

I'll check if Katello uses jquery-ui or are those just leftovers

Apr 26 '24 17:04 MariaAga

If they still are, I wonder what else is silently relying on it. If other plugins don't then we could consider moving it to katello, until it's dropped there

Apr 26 '24 18:04 ekohl

Added a PR to Katello https://github.com/Katello/katello/pull/10982

May 02 '24 08:05 MariaAga

In https://github.com/theforeman/actions?tab=readme-ov-file#foreman-plugin-ruby-tests I've added documentation on how to run CI for plugins against this PR. You'd use foreman_version: refs/pull/10142/head in the YAML. Though I wonder how many cases we would actually find vs how many cases actually exist.

May 02 '24 08:05 ekohl