foreman icon indicating copy to clipboard operation
foreman copied to clipboard

Refs #37010 - Ensure correct yaml for netplan

Open bastian-src opened this issue 1 year ago • 1 comments

The changes in #9967 introduce the save navigation operator. Unfortunately, the corresponding snippet relies on the passed arguments being true/false instead of nil.

@ekohl should we add a safety check to the preseed_netplan_generic_interface that turns nil into false or revert the save navigator change in this snippet?

Or am I overseeing something here?

// Setting it as Draft as this is just a proposal that must be applied to all snippet calls.

bastian-src avatar Feb 02 '24 14:02 bastian-src

Katello tests seem unrelated AFAIK.

bastian-src avatar Feb 14 '24 10:02 bastian-src

@sbernhard you're right with your comments. I've changed the corresponding lines.

bastian-src avatar Mar 12 '24 08:03 bastian-src

@sbernhard you can only merge with Refs if you cherry pick it to the stable branch. Otherwise you'll end up with a missing commit.

@ekohl should we add a safety check to the preseed_netplan_generic_interface that turns nil into false or revert the save navigator change in this snippet?

Apologies for missing this. I'd actually say the easier fix is to enforce a boolean in preseed_netplan_generic_interface.erb. I think https://github.com/theforeman/foreman/pull/10102 is that.

ekohl avatar Mar 19 '24 14:03 ekohl