foreman-packaging icon indicating copy to clipboard operation
foreman-packaging copied to clipboard

Fixes #35852 - Add isoinfo dependency

Open bastian-src opened this issue 2 years ago • 3 comments

Refer to Smart Proxy PR.

Adds dependency isoinfo which is used to extract images.

bastian-src avatar Dec 12 '22 10:12 bastian-src

Where is that package from? I don't see it in CentOS?

Edit: ah, it's in the genisoimage package, so you need to depend on that, or use the full path /usr/bin/isoinfo so that dnf knows it needs to resolve a path not a package

evgeni avatar Dec 12 '22 11:12 evgeni

ah thanks! I thought it would be only for debian genisoimage. Gonna change it accordingly!

bastian-src avatar Dec 12 '22 12:12 bastian-src

@evgeni this feature adds a folder /var/lib/foreman-proxy/tftp/system_images to store OS iso images. Do you think it's okay to implement it with these static paths or is it better to create a variable for {_sharedstatedir}/%{name}/tftp/system_images? (I'll adapt the deb PR accordingly)

bastian-src avatar Dec 14 '22 16:12 bastian-src