foreman-packaging icon indicating copy to clipboard operation
foreman-packaging copied to clipboard

Refs #18539 - Expand foreman_{assets,webpack}_plugin macros

Open ekohl opened this issue 1 year ago • 5 comments

These macros now include the directories above it so plugins properly own them. That means on removal (and upgrade is a special case of removal) they're cleaned up.

This means the macro now only works in the %files section, but in practice that's the only place it's used.

ekohl avatar Sep 11 '24 17:09 ekohl

My thought was to fork the COPR repo that was created for this PR and build a plugin there.

ekohl avatar Sep 11 '24 18:09 ekohl

https://copr.fedorainfracloud.org/coprs/ekohl/foreman-packaging-pr-11233/build/8009724/

ekohl avatar Sep 11 '24 19:09 ekohl

Of course I forgot to set up the repos. https://copr.fedorainfracloud.org/coprs/ekohl/foreman-packaging-pr-11233/build/8009796/ tries it again.

ekohl avatar Sep 11 '24 19:09 ekohl

I'm tempted to say this is a relevant build failure.

+ '[' -e /builddir/build/BUILDROOT/rubygem-foreman_remote_execution-14.0.0-1.fm3_13.el8.x86_64
/var/tmp/rpm-tmp.K20k5c: line 77: [: missing `]'


RPM build errors:
error: Bad exit status from /var/tmp/rpm-tmp.K20k5c (%install)
    Bad exit status from /var/tmp/rpm-tmp.K20k5c (%install)

ekohl avatar Sep 11 '24 20:09 ekohl

Well, damn, that macro is used in the precompile_plugin macro.

🐢

evgeni avatar Sep 11 '24 20:09 evgeni