foreman-packaging icon indicating copy to clipboard operation
foreman-packaging copied to clipboard

Refs #18539 - Introduce foreman_plugin_files in foreman.macros

Open ekohl opened this issue 1 year ago • 2 comments

This allows plugins to use %files -f foreman_plugin_files and automatically get the correct files section, based on the foreman_bundlerd_file and foreman_precompile_plugin macros (and their options).

ekohl avatar Aug 30 '24 09:08 ekohl

But this also means we need to adjust every single plugin spec, while just adjusting the existing macros does not require it?

evgeni avatar Aug 30 '24 10:08 evgeni

True, but the idea I have is to and up with less logic in gem2rpm/foreman_plugin.spec.erb anyway. Combined with https://github.com/theforeman/foreman-packaging/pull/8414 I'd like to get rid of a lot of templating.

Perhaps it's better to separate that out, but I wanted to see. Friday always has time for a bit of experimentation, right?

ekohl avatar Aug 30 '24 10:08 ekohl