foreman-installer icon indicating copy to clipboard operation
foreman-installer copied to clipboard

Fixes #37261 Add gitlab ci configuration

Open dosas opened this issue 11 months ago • 9 comments

dosas avatar Mar 14 '24 11:03 dosas

Can one of the admins verify this patch?

theforeman-bot avatar Mar 14 '24 11:03 theforeman-bot

Build failing due to network issues:

/usr/share/ruby/net/protocol.rb:46:in `connect_nonblock': Unable to connect to https://forgeapi.puppet.com (for request /v3/releases/puppet-systemd-6.6.0): Connection reset by peer - SSL_connect (Faraday::ConnectionFailed)

dosas avatar Mar 14 '24 11:03 dosas

You missed the - between the issue number and the description in the commit message.

The parser didn't mind ;)

dosas avatar Mar 14 '24 14:03 dosas

I think it's OK to include this. @evgeni / @ehelms is this also something we would use downstream? Could it conflict with anything?

I recall talking to someone at cfgmgmtcamp that having gitlab ci stuff would be fine and we could ideally re-use it downstream -- or rip it out there.

evgeni avatar Mar 14 '24 18:03 evgeni

It could conflict, but I would expect that we can modify this or attempt to find ways to co-exist since no one version of it should be the source of truth given nothing verifies this directly in our repo.

On Thu, Mar 14, 2024, 11:27 AM Evgeni Golov @.***> wrote:

I think it's OK to include this. @evgeni https://github.com/evgeni / @ehelms https://github.com/ehelms is this also something we would use downstream? Could it conflict with anything?

I recall talking to someone at cfgmgmtcamp that having gitlab ci stuff would be fine and we could ideally re-use it downstream -- or rip it out there.

— Reply to this email directly, view it on GitHub https://github.com/theforeman/foreman-installer/pull/918#issuecomment-1998075296, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACHT44ZATKP5DIGNVGIPJDYYHT2XAVCNFSM6AAAAABEV3XWHCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOJYGA3TKMRZGY . You are receiving this because you were mentioned.Message ID: @.***>

ehelms avatar Mar 14 '24 18:03 ehelms

How can we fix the stuck test?

dosas avatar Mar 19 '24 10:03 dosas

[test foreman-installer]

evgeni avatar Mar 19 '24 10:03 evgeni

Should we merge or combine this with existing downstream configurations first?

dosas avatar Mar 19 '24 11:03 dosas

I'm fine merging this as-is and improving from there.

evgeni avatar Mar 19 '24 11:03 evgeni

I would merge it, if I could ;)

dosas avatar Mar 21 '24 15:03 dosas

[test foreman-installer]

dosas avatar Mar 26 '24 08:03 dosas

@evgeni Could you please trigger the installer-tests?

dosas avatar Mar 27 '24 08:03 dosas

ok to test

evgeni avatar Mar 27 '24 08:03 evgeni

Is this good to merge?

dosas avatar Apr 02 '24 11:04 dosas