foreman-installer
foreman-installer copied to clipboard
Fixes #37261 Add gitlab ci configuration
Can one of the admins verify this patch?
Build failing due to network issues:
/usr/share/ruby/net/protocol.rb:46:in `connect_nonblock': Unable to connect to https://forgeapi.puppet.com (for request /v3/releases/puppet-systemd-6.6.0): Connection reset by peer - SSL_connect (Faraday::ConnectionFailed)
You missed the
-
between the issue number and the description in the commit message.
The parser didn't mind ;)
I think it's OK to include this. @evgeni / @ehelms is this also something we would use downstream? Could it conflict with anything?
I recall talking to someone at cfgmgmtcamp that having gitlab ci stuff would be fine and we could ideally re-use it downstream -- or rip it out there.
It could conflict, but I would expect that we can modify this or attempt to find ways to co-exist since no one version of it should be the source of truth given nothing verifies this directly in our repo.
On Thu, Mar 14, 2024, 11:27 AM Evgeni Golov @.***> wrote:
I think it's OK to include this. @evgeni https://github.com/evgeni / @ehelms https://github.com/ehelms is this also something we would use downstream? Could it conflict with anything?
I recall talking to someone at cfgmgmtcamp that having gitlab ci stuff would be fine and we could ideally re-use it downstream -- or rip it out there.
— Reply to this email directly, view it on GitHub https://github.com/theforeman/foreman-installer/pull/918#issuecomment-1998075296, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACHT44ZATKP5DIGNVGIPJDYYHT2XAVCNFSM6AAAAABEV3XWHCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOJYGA3TKMRZGY . You are receiving this because you were mentioned.Message ID: @.***>
How can we fix the stuck test?
[test foreman-installer]
Should we merge or combine this with existing downstream configurations first?
I'm fine merging this as-is and improving from there.
I would merge it, if I could ;)
[test foreman-installer]
@evgeni Could you please trigger the installer-tests?
ok to test
Is this good to merge?