foreman-installer icon indicating copy to clipboard operation
foreman-installer copied to clipboard

Fixes #37063 - Add feature in katello-certs-check to verify if CA bundle has any certificates with trust rules

Open jpasqualetto opened this issue 1 year ago • 3 comments

jpasqualetto avatar Jan 18 '24 17:01 jpasqualetto

Do you think you could add a test case for this? We have certificate fixtures where we generate different of these failing scenarios (https://github.com/theforeman/foreman-installer/blob/develop/spec/fixtures/katello-certs-check/create_cert.sh) and then we test that the script does what we expect when encountering said type (https://github.com/theforeman/foreman-installer/blob/develop/spec/katello_certs_check_spec.rb).

ehelms avatar Jan 18 '24 18:01 ehelms

I'll have a look at the test case. I may need some help with it.

jpasqualetto avatar Jan 18 '24 18:01 jpasqualetto

I'll have a look at the test case. I may need some help with it.

I pushed an update with a test case and fixed the indentation issues. Let me know if anything else is needed.

jpasqualetto avatar Jan 22 '24 15:01 jpasqualetto