foreman-installer icon indicating copy to clipboard operation
foreman-installer copied to clipboard

Update Rubocop version & fix offenses

Open archanaserver opened this issue 2 years ago • 1 comments

This PR updates the RuboCop version and addresses various code style offenses.

archanaserver avatar Sep 20 '23 05:09 archanaserver

I would also require an up to date rubocop. What do we need to do to get this forward?

dosas avatar Mar 13 '24 15:03 dosas

@archanaserver Could you implement the changes?

dosas avatar Apr 11 '24 11:04 dosas

@archanaserver Could you implement the changes?

@dosas I recommend handling these changes through a separate pull request. Alternatively, we could consider incorporating them when the theforeman-rubocop gem releases its next version with the updated RuboCop version. You can find more details about this here: https://community.theforeman.org/t/standardizing-rubocop-with-theforeman-rubocop/37239 Let me know your thoughts!

archanaserver avatar Apr 12 '24 10:04 archanaserver

@archanaserver Could you implement the changes?

@dosas I recommend handling these changes through a separate pull request. Alternatively, we could consider incorporating them when the theforeman-rubocop gem releases its next version with the updated RuboCop version.

I don't understand AFAIK you already implemented the requested changes in a commit?

You can find more details about this here: https://community.theforeman.org/t/standardizing-rubocop-with-theforeman-rubocop/37239 Let me know your thoughts!

LGTM

dosas avatar Apr 15 '24 08:04 dosas

[test foreman-installer]

ehelms avatar Apr 29 '24 12:04 ehelms