foreman-documentation icon indicating copy to clipboard operation
foreman-documentation copied to clipboard

Dissociate Smart Proxies unmanaged IPv6

Open Lennonka opened this issue 11 months ago • 10 comments

What changes are you introducing?

Adding important instructions for subnets and domains in IPv6 networks, where DHCP and DNS cannot be managed by Foreman

Why are you introducing these changes? (Explanation, links to references, issues, etc.)

  • Users need to know this if they work in IPv6 networks.
  • "Once no proxies are associated, the system will allow creating hosts without IPs specified." SAT-30604

Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)

Checklists

  • [x] I am okay with my commits getting squashed when you merge this PR.
  • [x] I am familiar with the contributing guidelines.

Please cherry-pick my commits into:

  • [x] Foreman 3.14

Lennonka avatar Feb 05 '25 17:02 Lennonka

ACK, makes sense

ShimShtein avatar Feb 09 '25 13:02 ShimShtein

I think it's a bug this can be done in the first place: the DHCP management is IPv4-only and we know the subnet type

ekohl avatar Feb 10 '25 10:02 ekohl

So I can merge this, right?

Lennonka avatar Mar 10 '25 13:03 Lennonka

So I can merge this, right?

I have the same question :) @ShimShtein's ack means tech review done but there is still one open thread: https://github.com/theforeman/foreman-documentation/pull/3645/files#r1948841674 Is it a blocking or non-blocking comment?

aneta-petrova avatar Mar 12 '25 15:03 aneta-petrova

Unsetting tech review because there is still interest in continuing the discussion.

aneta-petrova avatar Mar 20 '25 08:03 aneta-petrova

@ShimShtein @ekohl What are we gonna do about this?

Lennonka avatar Apr 22 '25 09:04 Lennonka

@ekohl I would say that we should take the discussion to our forum, and unblock this PR. IMHO it just describes the current state, and how to work with it, so it gives enough benefit. Later on we can improve the documentation further.

ShimShtein avatar Apr 22 '25 09:04 ShimShtein

There are 3 changes in this PR:

  • Stylistic of using the correct DNS/TFTP ID
  • Changing the xref
  • Adding warnings for IPv6 management

The first 2 looks correct to me, but I still maintain that the warnings for IPv6 management are invalid.

Combining multiple changes in the same PR is generally a bad thing because if there's an issue in one of the changes means that none of the changes get in. That's why I always hammer on separating changes when possible.

My recommendation would be to submit the first 2 changes as a separate PR and keep this open to resolve the discussion. I think having asking more people for input on the forum to get more opinions is a good suggestion from @ShimShtein.

ekohl avatar Apr 22 '25 11:04 ekohl

I've split off the cosmetic improvements to #3812

Lennonka avatar Apr 28 '25 11:04 Lennonka

@ekohl @ShimShtein Can I just close this?

Lennonka avatar Oct 07 '25 18:10 Lennonka

I'm in favor of closing it.

ShimShtein avatar Oct 19 '25 12:10 ShimShtein